Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Tree does not appear to be filtering out User Sets based on permissions #4

Open
mrscottelliott opened this issue Apr 23, 2014 · 0 comments

Comments

@mrscottelliott
Copy link

The User Set selection tree in the 'Course Completion By User Set Report' doesn't seem to be aware of permission restrictions like the dropdown is.

I think I found the offending code and a fix. At least it seems to do the trick for me!

Line 582 of elis/program/lib/filtering/clustertree.php

    if ($clusters = cluster_get_listing('priority, name', 'ASC', 0, 0, '', '', array('parent' => 0))) {

Needs to add context checking to limit what user sets are visible. The following seems to do the trick.

    if ($clusters = cluster_get_listing('priority, name', 'ASC', 0, 0, '', '', array('parent' => 0, 'contexts' => $context_result))) {

I'm using the following versions of ELIS
ELIS Program Manager Version: 2.5.1.5 (Build: 20131203)
ELIS Version: 2.5.1.5 (Build: 20131203)

If I did indeed find the problem and the appropriate location for a fix, it looks like it could be used on more recent versions as well.

Hope this helps!

Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant