-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
history.push() stopped working after upgrading to v5 #805
Comments
Same issue: |
I am facing the same issue. Its look like there is some issue in the newest version "5.0.0" of history package. For now we can change its version to "4.10.1" which works for me. |
Looks like a duplicate of #803 |
Here is the minimal code to reproduce this issue in the browser: import React from 'react'
import { Router, Switch, Route } from 'react-router-dom'
import { createBrowserHistory } from 'history'
const history = createBrowserHistory()
export default () => (
<Router history={history}>
<Switch>
<Route path="/target">
<h2>Target</h2>
</Route>
<Route path="/">
<h2>Home</h2>
<button onClick={() => history.push('/target')}>Push</button>
</Route>
</Switch>
</Router>
) URL is changed, but it seems that no route is matched after Downgrading to |
same thing, we are using hash router and |
Have you guys check the migration list? https://github.com/ReactTraining/react-router/blob/dev/docs/advanced-guides/migrating-5-to-6.md |
@brendonco I think this issue is regarding upgrading to v5, not v6 |
I have recently upgraded history module from
4.10.1
to5.0.0
and noticed thathistory.push()
stopped working. After reverting it back to v4 it starts working.Using hash history with
react-router-redux
The text was updated successfully, but these errors were encountered: