Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Extend auto deployments to manually triggered deploys #95

Open
ejholmes opened this issue Sep 6, 2017 · 1 comment
Open

Extend auto deployments to manually triggered deploys #95

ejholmes opened this issue Sep 6, 2017 · 1 comment

Comments

@ejholmes
Copy link
Contributor

ejholmes commented Sep 6, 2017

If you try to /deploy something that has some pending commit statuses, you'll see a message like this:

I think it would be nice if the buttons were extended with an "Enqueue" button, which would queue it up to be deployed once the commit statuses were passing.

This could use all of the existing infrastructure for CD, so it'd be really easy to build.

@ejholmes
Copy link
Contributor Author

One thing that isn't so straightforward with this is that, when you request a deployment through /deploy, you're usually giving a ref (branch/tag, eg. "master") and the GitHub deployments API does it's magic by converting that ref to a commit sha to deploy.

The AutoDeployments infrastructure with SlashDeploy only deals in commit sha's, so SlashDeploy itself would need to do some work to resolve a ref to a sha. Lame. It'd be nice if the error returned when creating a deployment gave you the resolved ref.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant