This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
slashdeploy/locked
commit status
#62
Comments
Do you think #60 will solve this? When this happens, you'll get a DM from @slashdeploy saying:
|
That will be useful for letting people know their commits to master won't deploy. What I'm after here is to prevent committing to master when deploy is locked. (So that commits don't pile up and potentially introduce new problems when the unlock and deploy finally happens.) |
Ahhh, I see what you're saying. That's a really good idea, and I think would be relatively straightforward to implement. |
Credit goes to @jerrysu. Ran into him on my walk into work the other day and his new stack has this feature. He said they have almost a dozen status checks. (e.g. linting is checked separately from unit tests) |
ejholmes
changed the title
Deploy lock to lock merging to master
Aug 31, 2016
slashdeploy/locked
commit status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When prod deploy is locked sometimes lots of commits pile up in master that don't get deployed until the unlock, which weighs the unlock with unnecessary risk.
Would be great to have a Github status check that fails if production is locked.
The text was updated successfully, but these errors were encountered: