chore: clean useless things

.travis.yml

@@ -21,8 +21,6 @@ jobs:
       script: composer run-script static-analysis
     - script: composer run-script code-style-check
       name: PHP CS-FIXER
-    - script: composer run-script rector-check
-      name: RECTOR
     - script: composer run-script unit-test
       after_script: ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
       name: UNIT-TESTS

README.md

@@ -20,7 +20,7 @@ Installation
 ------------
 
 ````bash
-$ composer require rem42/scraper "2.x-dev"
+composer require rem42/scraper "2.x-dev"
 ````
 
 Requirement

composer.json

@@ -15,11 +15,10 @@
     "symfony/serializer-pack": "^1.0"
   },
   "require-dev": {
-    "rector/rector": "0.7.*",
     "rem42/php-cs-fixer-config": "^1.0",
-    "phpstan/phpstan": "0.12.*",
-    "phpunit/phpunit": "9.*",
-    "php-coveralls/php-coveralls": "2.*"
+    "phpstan/phpstan": "^0.12",
+    "phpunit/phpunit": "^9.0",
+    "php-coveralls/php-coveralls": "^2.0"
   },
   "suggest": {
     "ext-json": "If you need to support JSON format",
@@ -49,8 +48,6 @@
     "static-analysis": "./bin/phpstan analyse src --level=max --no-progress -vvv",
     "code-style-check": "./bin/php-cs-fixer fix --dry-run --verbose",
     "code-style-fix": "./bin/php-cs-fixer fix",
-    "rector-check": "./bin/rector process --dry-run",
-    "rector-fix": "./bin/rector process",
     "unit-test": "./bin/phpunit"
   }
 }

src/Annotation/ExtractAnnotation.php

@@ -17,7 +17,7 @@ final class ExtractAnnotation
 
     public function __construct(AnnotationReader $reader, ScraperRequest $request)
     {
-        $this->reflexionClass    = new \ReflectionClass(get_class($request));
+        $this->reflexionClass    = new \ReflectionClass(\get_class($request));
         $this->reader            = $reader;
         $this->request           = $request;
         $this->scraperAnnotation = new Scraper();
@@ -33,9 +33,9 @@ public static function extract(ScraperRequest $request): Scraper
     }
 
     /**
-     * @param \ReflectionClass<ScraperRequest>|null $reflectionClass
+     * @param null|\ReflectionClass<ScraperRequest> $reflectionClass
      */
-    private function recursive(\ReflectionClass $reflectionClass =  null): void
+    private function recursive(\ReflectionClass $reflectionClass = null): void
     {
         if (null === $reflectionClass) {
             $reflectionClass = $this->reflexionClass;
@@ -61,7 +61,7 @@ private function extractAnnotation(Scraper $annotation): void
         $vars = get_object_vars($this->scraperAnnotation);
         // Initializing class properties
         foreach ($vars as $property => $value) {
-            $scraper->$property = $value;
+            $scraper->{$property} = $value;
         }
 
         $vars = get_object_vars($annotation);
@@ -70,7 +70,7 @@ private function extractAnnotation(Scraper $annotation): void
             if (preg_match_all('#{(.*?)}#', $value, $matchs)) {
                 foreach ($matchs[1] as $match) {
                     $method       = 'get' . ucfirst($match);
-                    $requestValue = $this->request->$method();
+                    $requestValue = $this->request->{$method}();
                     $value        = str_replace('{' . $match . '}', $requestValue, $value);
                 }
             }
@@ -80,7 +80,7 @@ private function extractAnnotation(Scraper $annotation): void
                 continue;
             }
 
-            $scraper->$property = $value;
+            $scraper->{$property} = $value;
         }
 
         $this->scraperAnnotation = $scraper;
@@ -92,7 +92,7 @@ private function handlePath(Scraper $scraper, ?string $path = null): void
             return;
         }
 
-        if (strlen($path) > 0 && '/' === $path[0]) {
+        if (\strlen($path) > 0 && '/' === $path[0]) {
             $scraper->path = $path;
         } elseif (isset($scraper->path)) {
             $scraper->path = rtrim($scraper->path, '/') . '/' . ltrim($path, '/');

src/Api/ApiInterface.php

@@ -5,7 +5,7 @@
 interface ApiInterface
 {
     /**
-     * @return object|array<object>|bool
+     * @return array<object>|bool|object
      */
     public function execute();
 }

src/Client.php

@@ -24,12 +24,12 @@ public function __construct(HttpClientInterface $httpClient)
     }
 
     /**
-     * @return object|array<object>|bool
+     * @return array<object>|bool|object
      */
     public function send(ScraperRequest $request)
     {
-        $this->request    = $request;
-        $annotation       = ExtractAnnotation::extract($this->request);
+        $this->request = $request;
+        $annotation    = ExtractAnnotation::extract($this->request);
 
         $options = [];
 

src/Request/RequestBody.php

@@ -5,7 +5,7 @@
 interface RequestBody
 {
     /**
-     * @return array<string, string>|string|resource
+     * @return array<string, string>|resource|string
      */
     public function getBody();
 }

tests/Annotation/ExtractAnnotationTest.php

@@ -11,6 +11,9 @@
 use Scraper\Scraper\Tests\Fixtures\TestWithAnnotationParametersRequest;
 use Scraper\Scraper\Tests\Fixtures\TestWithoutAnnotationRequest;
 
+/**
+ * @internal
+ */
 final class ExtractAnnotationTest extends TestCase
 {
     public function testExtractRequest(): void

tests/ClientTest.php

@@ -14,6 +14,9 @@
 use Symfony\Contracts\HttpClient\ResponseInterface;
 use Symfony\Contracts\HttpClient\ResponseStreamInterface;
 
+/**
+ * @internal
+ */
 final class ClientTest extends TestCase
 {
     public function testSend(): void
@@ -32,7 +35,7 @@ public function testSend(): void
 
         $result = $client->send($request);
 
-        $this->assertEquals(true, $result);
+        $this->assertTrue($result);
     }
 
     public function testResponseWithException(): void
@@ -45,10 +48,9 @@ public function testResponseWithException(): void
         $client = new Client($httpClient);
 
         $request = new TestRequest();
-        //$this->expectException(ServerExceptionInterface::class);
         $this->expectException(\Exception::class);
 
-        $result = $client->send($request);
+        $client->send($request);
     }
 
     public function testWithAllOptions(): void
@@ -135,7 +137,7 @@ public function testPrivateSend(): void
 
         $client = new Client($httpClient);
 
-        $reflection = new \ReflectionClass(get_class($client));
+        $reflection = new \ReflectionClass(\get_class($client));
         $method     = $reflection->getMethod('getApiReflectionClass');
         $method->setAccessible(true);
 

tests/Fixtures/HttpClientTest.php

@@ -6,6 +6,10 @@
 use Symfony\Contracts\HttpClient\ResponseInterface;
 use Symfony\Contracts\HttpClient\ResponseStreamInterface;
 
+/**
+ * @internal
+ * @coversNothing
+ */
 final class HttpClientTest implements HttpClientInterface
 {
     private ResponseInterface $response;