Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: limit the size of Queue in LoggingThread #249

Merged
merged 2 commits into from
Mar 14, 2024
Merged

worker: limit the size of Queue in LoggingThread #249

merged 2 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. worker: limit the size of the queue in LoggingThread 

    This change fixes two issues:

1. By limiting the maximum size of the Queue, we avoid consuming all
   available memory on given machine to store its contents.

2. By limiting the amount of retrieved elements from the Queue, we avoid
   consuming all available memory to construct the byte string to send and
   we avoid stalling the upload of logs to the hub.
    @lzaoral
    lzaoral committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    35178ff View commit details
    Browse the repository at this point in the history

  2. worker: log exceptions in LoggingThread

    @lzaoral
    lzaoral committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fa58f81 View commit details
    Browse the repository at this point in the history