worker: limit the size of Queue in LoggingThread
#249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two issues:
By limiting the maximum size of the Queue, we avoid consuming all
available memory on given machine to store its contents.
By limiting the amount of retrieved elements from the Queue, we avoid
consuming all available memory to construct the byte string to send and
we avoid stalling the upload of logs to the hub.
Also, log all skipped exceptions caught in
LoggingThread
to ease debugging.