tback: make Traceback printing compatible with Python 3
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because kobo only supports Python 3.6+, we can just return a
concatenated unicode string with the given exception.
Fixes the following incorrectly formatted output:
```
$ cat test.py
from kobo.tback import set_except_hook
set_except_hook()
assert False
$ python3 test.py
b'Traceback (most recent call last):\n File "/Users/lzaoral/redhat/OpenScanHub/kobo/test.py", line 4, in <module>\n assert False\nAssertionError\nFrame <module> in /Users/lzaoral/redhat/OpenScanHub/kobo/test.py at line 4\n<CODE>\n 1 from kobo.tback import set_except_hook\n 2 set_except_hook()\n 3 \n--> 4 assert False\n</CODE>\n<LOCALS>\n __annotations__ = {}\n __builtins__ = <module \'builtins\' (built-in)>\n __cached__ = None\n __doc__ = None\n __file__ = \'/Users/lzaoral/redhat/OpenScanHub/kobo/test.py\'\n __loader__ = <_frozen_importlib_external.SourceFileLoader object at 0x100711650>\n __name__ = \'__main__\'\n __package__ = None\n __spec__ = None\n set_except_hook = <function set_except_hook at 0x10082df80>\n</LOCALS>\n'
```
`Traceback.get_traceback` no longer produces broken output. Therefore, our reimplementation of `xmlrpc.client.Fault.__repr__` can be greatly simplified.
rohanpm
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
koboonly supports Python 3.6+, we can just return aconcatenated Unicode string with the given exception.
Fixes the following incorrectly formatted output: