-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable restrictions for user list/detail view. #228
Conversation
I added several test cases, which makes sure once configured in settings, corresponding user list/detail view are no longer accessible. However I was unable to login using the test client in
and
Neither worked. I failed to find a neat way to do this. Also after looked into the PTAL. |
I believe the above works if given a correct username and password, but no users seem to exist by default. The following worked for me, to create a user before authenticating with it:
|
I guess my mistake was that I created the user and specified the password at the same time, something like this:
which just won't work! I'll try use |
cd56958
to
fe0d42f
Compare
fe0d42f
to
7dbc953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please arrange for one other person who also works on openscanhub to post a +1 on this so that I know you guys have agreed on the solution?
@kdudka would you mind give a look when got time? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it works as expected. Thanks!
With this update, the user list/detail view will be accessible only to staff users, this ensures the app meets compliance requirements. Related: release-engineering/kobo#228 Related: release-engineering/kobo#209 Related: https://issues.redhat.com/browse/OSH-78
With this update, the user list/detail view will be accessible only to staff users, this ensures the app meets compliance requirements. Related: release-engineering/kobo#228 Related: release-engineering/kobo#209 Related: https://issues.redhat.com/browse/OSH-78
An attempt to resolve #209