Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: Return original SKU if Gen1 & Gen2 are set #60

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

JAVGan
Copy link
Collaborator

@JAVGan JAVGan commented Oct 7, 2024

This commit updates the ms_azure.utils.update_skus to not update the SKUs if both Gen1 and Gen2 are provided, instead it will return them to prevent erros by trying to change the SKU names with a possible new one which follows the strict naming convention.

Refers to SPSTRAT-416

This commit updates the `ms_azure.utils.update_skus` to not update the
SKUs if both Gen1 and Gen2 are provided, instead it will return them to
prevent erros by trying to change the SKU names with a possible new one
which follows the strict naming convention.

Refers to SPSTRAT-416
@JAVGan
Copy link
Collaborator Author

JAVGan commented Oct 7, 2024

@lslebodn @jajreidy PTAL

Copy link
Collaborator

@jajreidy jajreidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAVGan JAVGan merged commit 182b439 into main Oct 7, 2024
22 checks passed
@JAVGan JAVGan deleted the skus_once_again branch October 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants