Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade to Protobuf Edition 2024 #135

Open
meling opened this issue Dec 12, 2024 · 1 comment
Open

Chore: Upgrade to Protobuf Edition 2024 #135

meling opened this issue Dec 12, 2024 · 1 comment

Comments

@meling
Copy link
Member

meling commented Dec 12, 2024

We should take advantage of The new Opaque API coming in the new protobuf 2024 edition (should be released early 2025.)

Note: It should be possible to automate some or all of this using the open2opaque tool.

@meling
Copy link
Member Author

meling commented Dec 25, 2024

A quick experiment resulted in the following issue:

% make protos
protoc -I=.:/Users/meling/go/pkg/mod/github.com/relab/[email protected]:internal/proto \
		--go_out=paths=source_relative:. \
		--gorums_out=paths=source_relative:. \
		internal/proto/clientpb/client.proto
internal/proto/clientpb/client.proto: is an editions file, but code generator protoc-gen-gorums hasn't been updated to support editions yet.  Please ask the owner of this code generator to add support or switch back to proto2/proto3.

See https://protobuf.dev/editions/overview/ for more information.--gorums_out: 
make: *** [internal/proto/clientpb/client.pb.go] Error 1

Hence, we must first update gorums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant