Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter for queue status #164

Open
xrl opened this issue Feb 1, 2021 · 1 comment
Open

Prometheus exporter for queue status #164

xrl opened this issue Feb 1, 2021 · 1 comment

Comments

@xrl
Copy link
Contributor

xrl commented Feb 1, 2021

I'm starting to "prometheus all the things" in our rails application. They have support for ruby garbage collector, rails, puma, activerecord, etc, would this project be open to support on the semantic logger operational metrics?

I'd love to get stats like

  • Count of all log lines processed
  • Count of all rejected log lines
  • Size of queues
  • Thoughts on other properties to instrument?

I'm using: https://github.com/discourse/prometheus_exporter

I could author instrumentation for semantic logger but I'm not sure where to include it. I could put it in this code base? Or would you prefer it's a third party repo?

Perhaps this library could make a SemanticLogger.stats property like they do on Puma? I'm looking at https://github.com/puma/puma/blob/64c0153cd0bd2bb0fe85258e17dad538067c6484/lib/puma.rb#L28

@reidmorrison
Copy link
Owner

Yes, adding stats directly to Semantic Logger would be a useful addition. Just be sure that it is thread safe and does not slow down each of the concurrent appenders. Some appenders have their own queues and worker threads too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants