Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to hast-util-to-mdast 9.x #15

Closed
wants to merge 3 commits into from

Conversation

tripodsan
Copy link

BREAKING CHANGE: Depends on [email protected]

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Upgrade to hast-util-to-mdast 9.x

@wooorm I don't understand the tests and the types enough to fix the tests.... any hints ?

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 18, 2023
@wooorm
Copy link
Member

wooorm commented Jan 18, 2023

Hey hey! Thank you!!

TS 4.9 changed a lot of stuff unfortunately. That’s why it all errors. Not very hard to fix when you know how it works!

As you noticed, I’m taking time to upgrade everything in the ecosystem. Most of it is pretty small. But there will be several breaking changes, including from micromark. To ease migration, I want to batch the majors in a relatively short time span. And before that moment is there, it’ll require about a month or so of work on micromark.

For now, if you really want to upgrade, I’d recommend a tiny fork for now:

function (options) {
    return (hast) {
        return toMdast(hast, options)
    }
}

Also taking this moment, as you’re heavily using the ecosystem, to ask whether you have requests for some breaking changes that should go somewhere!

@tripodsan
Copy link
Author

thanks for the reply. I understand.

Also taking this moment, as you’re heavily using the ecosystem, to ask whether you have requests for some breaking changes that should go somewhere!

not at the moment, I think :-)

@wooorm
Copy link
Member

wooorm commented Aug 31, 2023

done! https://github.com/rehypejs/rehype-remark/releases/tag/10.0.0

@wooorm wooorm closed this Aug 31, 2023
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 31, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants