Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating github releases from non-master #237

Open
kcpevey opened this issue Oct 28, 2020 · 4 comments
Open

Creating github releases from non-master #237

kcpevey opened this issue Oct 28, 2020 · 4 comments

Comments

@kcpevey
Copy link

kcpevey commented Oct 28, 2020

Due to github's change from naming the base branch main instead of master, I had to update these lines to get my github release action to work since it assumed that I was releasing from master.

However, I would also contend that its possible to release from any branch, which would suggest that this option should be exposed to users.

@scopatz
Copy link
Collaborator

scopatz commented Oct 28, 2020

Thanks for reporting @kcpevey! Potential fix in #238 if you want to try it out

@kcpevey
Copy link
Author

kcpevey commented Oct 28, 2020

I'll give it a try!

@scopatz
Copy link
Collaborator

scopatz commented Oct 28, 2020

Great thanks!

@kcpevey
Copy link
Author

kcpevey commented Oct 28, 2020

Works great for me! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants