Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch arch migrator to cross-compilation by default #2930

Open
jakirkham opened this issue Aug 13, 2024 · 6 comments
Open

Switch arch migrator to cross-compilation by default #2930

jakirkham opened this issue Aug 13, 2024 · 6 comments

Comments

@jakirkham
Copy link
Contributor

Given the ongoing issues we have been experiencing with Travis CI ( conda-forge/status#185 ), think we should start using cross-compilation on Azure as the default for new Arch Migrator PRs. This way we start with a configuration that usually works (sometimes with tweaks) while still building about as quickly as a native build

@jakirkham
Copy link
Contributor Author

cc @beckermr (as we discussed this earlier)

@beckermr
Copy link
Contributor

Thanks for the bump! This should be on for feedstocks for yaml migrators, but not versions. We have a separate r-base cross-compile mini-migrator that will need to be added in places.

@jakirkham
Copy link
Contributor Author

jakirkham commented Aug 22, 2024

Right was thinking about ArchRebuild.migrate. Is that the right place for this?

Regarding R, do you mean adding this to RUCRTCleanup.migrate? Or were you thinking of something else?

Also do migrators like these get combined when one is applied (like R)? Or do they both need to include this logic? Or is there some better way to handle this in one place that multiple migrators can use?

@beckermr
Copy link
Contributor

We need to add them as minimigrators when making the main migrators.

@jakirkham
Copy link
Contributor Author

If we want to convert existing feedstocks, sure

This issue was about changing the default in new migrations

@beckermr
Copy link
Contributor

The defaults are set my mini migrators too for new things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants