Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-scripts nuked by osx-arm migrator #2927

Open
h-vetinari opened this issue Aug 12, 2024 · 4 comments
Open

R-scripts nuked by osx-arm migrator #2927

h-vetinari opened this issue Aug 12, 2024 · 4 comments

Comments

@h-vetinari
Copy link
Contributor

The bot added the following diff in conda-forge/r-arrow-feedstock#88:

--- a/recipe/build.sh
+++ b/recipe/build.sh
@@ -1,16 +1,6 @@
 #!/bin/bash
-set -ex

 export DISABLE_AUTOBREW=1

-# arrow uses C++17
-export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -std=c++17"
-export LIBARROW_BUILD=false
-
-if [[ "${target_platform}" == osx-* ]]; then
-    # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
-    export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
-fi
-
-# ${R_ARGS} necessary to support cross-compilation
-${R} CMD INSTALL --build r/. ${R_ARGS}
+# shellcheck disable=SC2086
+${R} CMD INSTALL --build . ${R_ARGS}

which looks like it's blindly (and incorrectly) overwriting the build script - @beckermr asked me to open an issue here.

I've looked at https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/arch.py, but cannot figure out why the osx-arm migrator would do that. Also of note, the linux-arches PR for the same branch did not cause such changes to the build script.

@beckermr
Copy link
Contributor

I expect this may be a minimigrator and not the primary one.

@h-vetinari
Copy link
Contributor Author

I expect this may be a minimigrator and not the primary one.

Yeah, but I couldn't find which one would do that. At least, none of the names in https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators stick out.

@beckermr
Copy link
Contributor

This happens here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/cross_compile.py#L365.

cc @isuruf for advice on how to proceed.

@beckermr
Copy link
Contributor

Likely related to the comment @isuruf made here: #2946 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants