Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to debug missing PR's to branches (different version releases) #2700

Open
ZzEeKkAa opened this issue Jun 6, 2024 · 5 comments
Open

How to debug missing PR's to branches (different version releases) #2700

ZzEeKkAa opened this issue Jun 6, 2024 · 5 comments

Comments

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Jun 6, 2024

llvm-spirv-feedstock does not have PRs to newer versions of llvm-spirv on the branches different from main:
There is branch 15.X branch with version=15.0.0. However there is a new release v15.0.1: https://github.com/KhronosGroup/SPIRV-LLVM-Translator/releases/tag/v15.0.1 . There is also an automated PR to main for 18.0.0 -> 18.0.1: conda-forge/llvm-spirv-feedstock#26

Issue is mentioned here: conda-forge/llvm-spirv-feedstock#23

@beckermr
Copy link
Contributor

beckermr commented Jun 6, 2024

The bot won't make these PRs. Making it do that is super hard for a few reasons.

  • We do not have conventions for how people label release branches.
  • The internal structure of the bot has too many assumptions to support that easily right now.

We are unlikely to be able to enable this soon.

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 6, 2024

@beckermr thank you for the fast reply! SPIRV-LLVM-Translator going to create patch releases for at least 4 different versions every month..
Are there any open discussions how to come to this point.

In a meantime, it will be handy to have a comment here, so that it is obvious that bot does not open automatic PRs for such branches.

@beckermr
Copy link
Contributor

beckermr commented Jun 6, 2024

We do not have any open discussions. A path forward has to:

  1. Specify how we infer that a branch on a feedstock gets version updates and what constraints those have. We could only support variants of branch names that match this regex (v)(([0-9]+\.)*)x (i.e., v5.6.x, 5.6.x, 5.x, etc.)
  2. Figure out how to migrate the bot's version information schemas to support more than one branch
  3. Update the bot's version search code to search for branches as well

This is all a big lift in terms of dev.

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 7, 2024

Thank you!

Does it mean if somebody will implement it that it looks into (v)(([0-9]+\.)*)x branches and opens PRs for them keeping the same prefix, the PR will be merged without redefining requirements.

If I would have time I can try to implement it and open a PR.

@beckermr
Copy link
Contributor

beckermr commented Jun 7, 2024

It's a bit more complicated than that and will require a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants