Infinite refresh loop when install plugin routes after starting the Prototype Kit

[simonwo]

Not sure why this happens, I suspect something to do with stale state on the page. The workaround is to close the tab and then start again, but we should do something about this because the instructions ask the user to run the PK before modifying the routes.

1. Create a new app and install the plugin
2. Open the documentation page for the plugin as requested
3. Make changes to the routes
4. Observe infinite loop of refreshing

[alaric-rd]

I am failing to recreate this.

I followed the steps:

1. Made a new app and installed the plugin via make prototype NAME=test
2. Found the plug in the plugins list at http://localhost:3000/manage-prototype/plugins-installed and clicked Help
3. As per the instructions, pasted the extra lines into app/routes.js
4. Went on to follow the instructions, adding my pages from the templates, then used my prototype to upload a .xlsx file

...all worked fine (Firefox 128.0 on NixOS). What am I doing wrong?

[rossjones]

It might possibly be related to alphagov/govuk-prototype-kit#2388 which suggests that the code here is to blame which is triggered by hasRestartedAfterError looking for the presence of an error file.