-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove amino converter workaround #105
Comments
ryanchristo
changed the title
Remove amino amino converter workaround
Remove amino converter workaround
Jul 13, 2023
This was referenced Jul 13, 2023
ryanchristo
added
the
nice to have
Would be nice as part of this epic, but no necessary
label
Jul 13, 2023
This was referenced Jul 25, 2023
ryanchristo
removed
the
nice to have
Would be nice as part of this epic, but no necessary
label
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks the removal of the amino converter workaround and is dependent on upstream fixes.
In #69, a workaround was implemented to support amino. In summary, the amino converters for several messages used within the application were not handling
undefined
values, which is how amino translates zero-values. We override the amino converters from the regen-js api pacakge (i.e.@regen-network/api
) with custom amino converters insrc/api/group.amino.ts
.In order to create custom amino converters, we had to import types from the
src
directory within the api package. The types are not available in thetypes
directory because the code within thesrc
directory includes typescript errors (regen-network/regen-js#84) and therefore will not compile. We had to manual resolve some typescript errors withinsrc
(which will be overwritten on runningcodegen
) and tag a release with manual changes (i.e.v1.0.0-alpha5
, which includes regen-network/regen-js#79 and regen-network/regen-js#87) in order to run and build the groups application without upstream typescript errors.Another thing to be aware of, and depending on the upstream solution, when we remove the amino converter workaround, we may need a solution for amino support with
MsgSubmitProposal
similar to what was proposed in cosmology-tech/telescope#281 for messages that create and update a group policy. The type we need forMsgSubmitProposal
is currently unavailable but also may not be necessary depending on the upstream solution. The partial implementation is included in #69.The text was updated successfully, but these errors were encountered: