Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payee / narration fields are possibly switched. #57

Open
redstreet opened this issue Apr 13, 2023 · 0 comments
Open

Payee / narration fields are possibly switched. #57

redstreet opened this issue Apr 13, 2023 · 0 comments

Comments

@redstreet
Copy link
Owner

See #55

I'd like to clean up the situation around payee/narration for good and do the right thing, whatever that is. It's fine to backward compatibility if needed for the benefit of getting this right for the longer run.

If at all you have the time and inclination figure out the full picture and submit a comprehensive solution, that would be great, and I'd rather accept that over the temporary fix of documenting it. If you're not inclined to, that's fine too: this needs to be documented and worked on at some point.

With that said, the things that come to mind are:

  • Beancount reference
  • solving for the comment here
  • solving for the investments transaction builder
  • ensuring the current importers don't break (it's okay if they don't do the same thing as earlier, and do the right thing instead; however, they shouldn't crash)
  • ensuring smart_importer works correctly with the solution
  • documenting methods to fix backward compatibility for users
m-d-brown added a commit to m-d-brown/beancount_reds_importers that referenced this issue Apr 14, 2023
m-d-brown added a commit to m-d-brown/beancount_reds_importers that referenced this issue Apr 14, 2023
m-d-brown added a commit to m-d-brown/beancount_reds_importers that referenced this issue Apr 14, 2023
scanta2 pushed a commit to scanta2/beancount_reds_importers that referenced this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant