From 327a0a0f77de3b34472f5aabeac00e406beff858 Mon Sep 17 00:00:00 2001 From: Martin Schneppenheim <23424570+weeco@users.noreply.github.com> Date: Tue, 22 Aug 2023 15:19:45 +0100 Subject: [PATCH] backend: fix linting issues (#820) --- backend/pkg/filesystem/util_unix_test.go | 13 +++++++------ backend/pkg/filesystem/util_windows_test.go | 9 +++++---- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/backend/pkg/filesystem/util_unix_test.go b/backend/pkg/filesystem/util_unix_test.go index 69685d946..009db7e66 100644 --- a/backend/pkg/filesystem/util_unix_test.go +++ b/backend/pkg/filesystem/util_unix_test.go @@ -16,10 +16,11 @@ import ( "testing" "time" - "github.com/redpanda-data/console/backend/pkg/config" "github.com/stretchr/testify/require" "github.com/stretchr/testify/suite" "go.uber.org/zap" + + "github.com/redpanda-data/console/backend/pkg/config" ) type FileSystemTestSuite struct { @@ -34,7 +35,7 @@ func TestSuite(t *testing.T) { suite.Run(t, &FileSystemTestSuite{}) } -func (s *FileSystemTestSuite) createBaseConfig() config.Filesystem { +func (*FileSystemTestSuite) createBaseConfig() config.Filesystem { cfg := config.Filesystem{} cfg.SetDefaults() cfg.Enabled = true @@ -49,15 +50,15 @@ func (s *FileSystemTestSuite) SetupSuite() { t := s.T() require := require.New(t) - os.Mkdir("testdata", 0775) + os.Mkdir("testdata", 0o750) os.Create("testdata/visible.txt") os.Create("testdata/.hidden.txt") - os.Mkdir("testdata/..hiddenFolder", 0775) + os.Mkdir("testdata/..hiddenFolder", 0o750) os.Create("testdata/..hiddenFolder/visible.txt") os.Create("testdata/..hiddenFolder/.hidden.txt") - os.Mkdir("testdata/visibleFolder", 0775) + os.Mkdir("testdata/visibleFolder", 0o750) os.Create("testdata/visibleFolder/visible.txt") os.Create("testdata/visibleFolder/.hidden.txt") @@ -75,7 +76,7 @@ func (s *FileSystemTestSuite) SetupSuite() { s.log = log } -func (s *FileSystemTestSuite) TearDownSuite() { +func (*FileSystemTestSuite) TearDownSuite() { os.RemoveAll("testdata") } diff --git a/backend/pkg/filesystem/util_windows_test.go b/backend/pkg/filesystem/util_windows_test.go index 8d15b1b06..1a6692eef 100644 --- a/backend/pkg/filesystem/util_windows_test.go +++ b/backend/pkg/filesystem/util_windows_test.go @@ -17,10 +17,11 @@ import ( "testing" "time" - "github.com/redpanda-data/console/backend/pkg/config" "github.com/stretchr/testify/require" "github.com/stretchr/testify/suite" "go.uber.org/zap" + + "github.com/redpanda-data/console/backend/pkg/config" ) type FileSystemTestSuite struct { @@ -62,19 +63,19 @@ func (s *FileSystemTestSuite) SetupSuite() { t := s.T() require := require.New(t) - os.Mkdir("testdata", 0775) + os.Mkdir("testdata", 0o775) os.Create("testdata\\visible.txt") os.Create("testdata\\hidden.txt") err := hide("testdata\\hidden.txt") require.NoError(err) - os.Mkdir("testdata\\hiddenFolder", 0775) + os.Mkdir("testdata\\hiddenFolder", 0o775) os.Create("testdata\\hiddenFolder\\visible.txt") os.Create("testdata\\hiddenFolder\\hidden.txt") err = hide("testdata\\hiddenFolder") require.NoError(err) - os.Mkdir("testdata\\visibleFolder", 0775) + os.Mkdir("testdata\\visibleFolder", 0o775) os.Create("testdata\\visibleFolder\\visible.txt") os.Create("testdata\\visibleFolder\\hidden.txt") err = hide("testdata\\visibleFolder\\hidden.txt")