-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite redot on top of ts-graphviz #25
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ignore-scripts=true | ||
package-lock=false |
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#!/usr/bin/env node | ||
import {createRequire} from 'node:module' | ||
import {args} from 'unified-args' | ||
// eslint-disable-next-line import/order | ||
import {redot} from 'redot' | ||
|
||
const require = createRequire(import.meta.url) | ||
|
||
const proc = require('redot/package.json') | ||
const cli = require('./package.json') | ||
|
||
const extensions = ['dot', 'gv'] | ||
|
||
args({ | ||
processor: redot, | ||
name: proc.name, | ||
description: cli.description, | ||
version: [ | ||
proc.name + ': ' + proc.version, | ||
cli.name + ': ' + cli.version | ||
].join(', '), | ||
pluginPrefix: proc.name, | ||
packageField: proc.name + 'Config', | ||
rcName: '.' + proc.name + 'rc', | ||
ignoreName: '.' + proc.name + 'ignore', | ||
extensions | ||
}) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
The MIT License (MIT) | ||
MIT License | ||
|
||
Copyright (c) 2014 Andrei Kashcha | ||
Copyright (c) 2018 Christian Murphy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn’t we keep the original license instead? It’s ok to rename it though. Maybe the original license should be copied to all packages as well. I’m not sure who made what. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The diff is a bit misleading, the original file wasn't a license, it was a notice. |
||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root of the issue is the newline between the
import
andrequire
With the original code or with your patch, the error is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this ESLint rule just isn’t very good, so I don’t worry about it