Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Code blocks don't render inside post #227

Open
omnigenous opened this issue Sep 14, 2024 · 2 comments · May be fixed by #323
Open

🐛 Bug Report: Code blocks don't render inside post #227

omnigenous opened this issue Sep 14, 2024 · 2 comments · May be fixed by #323
Labels
bug Something isn't working

Comments

@omnigenous
Copy link

Describe the bug

Code blocks don't render inside post but work inside comments

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Go to https://www.reddit.com/r/commandline/comments/1fe8uwc/want_to_share_how_i_refer_previous_command_i_use/
  2. See code blocks not redering inside post but comments code block work

Additional context / screenshot

2024-09-14_15-11-46

@omnigenous omnigenous added the bug Something isn't working label Sep 14, 2024
@ac615223s5
Copy link
Contributor

ac615223s5 commented Oct 24, 2024

@freedit-dev
Copy link
Contributor

Maybe we should render the markdown ourselves. I’m not sure whether we should render everything ourselves or just render the text that contains ``` blocks. What do you think? @sigaloid

selftext_html

<!-- SC_OFF --><div class="md"><p>This was a fun one that bit our open source project today...a log::error! macro in an enum that recursively printed itself.</p>

<p>Be careful out there println!ers 😂</p>

<p><a href="https://preview.redd.it/f7ikci93sx0e1.png?width=2016&amp;format=png&amp;auto=webp&amp;s=9b7ca26ae2f9f71b8b1960423caac2489c5f38ec">https://preview.redd.it/f7ikci93sx0e1.png?width=2016&amp;format=png&amp;auto=webp&amp;s=9b7ca26ae2f9f71b8b1960423caac2489c5f38ec</a></p>
</div><!-- SC_ON -->
text: This was a fun one that bit our open source project today...a log::error! macro in an enum that recursively printed itself.

Be careful out there println!ers 😂

https://preview.redd.it/f7ikci93sx0e1.png?width=2016&format=png&auto=webp&s=9b7ca26ae2f9f71b8b1960423caac2489c5f38ec

  

html: <!-- SC_OFF --><div class="md"><p>Despite the use of caching, my compile/test steps takes several minutes to execute, even if zero changes exist between runs.</p>

<p>```yaml
version: 2.1</p>

<p>commands:
  restore_cache_cmd:
    steps:
      - restore_cache:
          key: cache_cmd-v1-{{ arch }}-{{ checksum &quot;Cargo.lock&quot; }}</p>

<p>save_cache_cmd:
    steps:
      - save_cache:
          key: cache_cmd-v1-{{ arch }}-{{ checksum &quot;Cargo.lock&quot; }}
          paths:
            - &quot;~/.cargo&quot;
            - &quot;./target&quot;</p>

<p>jobs:
  # Precompile all the rust dependencies
  compile:
    executor: nix-executor
    steps:
      - restore_cache_cmd
      - run:
          name: Compile App
          command: |
            cargo zigbuild --target x86_64-unknown-linux-musl --bin server --release
      - save_cache_cmd
```</p>

<p>Critically, I see that the deps are not compiled but the binaries takes in this step like 6 min.</p>
</div><!-- SC_ON -->

selftext:

Despite the use of caching, my compile/test steps takes several minutes to execute, even if zero changes exist between runs.


```yaml
version: 2.1

commands:
  restore_cache_cmd:
    steps:
      - restore_cache:
          key: cache_cmd-v1-{{ arch }}-{{ checksum "Cargo.lock" }}

  save_cache_cmd:
    steps:
      - save_cache:
          key: cache_cmd-v1-{{ arch }}-{{ checksum "Cargo.lock" }}
          paths:
            - "~/.cargo"
            - "./target"

jobs:
  # Precompile all the rust dependencies
  compile:
    executor: nix-executor
    steps:
      - restore_cache_cmd
      - run:
          name: Compile App
          command: |
            cargo zigbuild --target x86_64-unknown-linux-musl --bin server --release
      - save_cache_cmd
```

Critically, I see that the deps are not compiled but the binaries takes in this step like 6 min.

freedit-dev added a commit to freedit-dev/redlib that referenced this issue Nov 15, 2024
@freedit-dev freedit-dev linked a pull request Nov 15, 2024 that will close this issue
freedit-dev added a commit to freedit-dev/redlib that referenced this issue Nov 15, 2024
freedit-dev added a commit to freedit-dev/redlib that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants