Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage ⬆️ 🧪 #54

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Oct 14, 2022

  • Unit tests
    • config.ts
    • metadata.ts
    • pull-request.ts
    • tag.ts
    • validation-feedback.ts
  • Integration tests

@jamacku jamacku self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #54 (f95b8b4) into main (d4b3a35) will increase coverage by 4.80%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   49.42%   54.23%   +4.80%     
==========================================
  Files           5        5              
  Lines         437      437              
  Branches       37       47      +10     
==========================================
+ Hits          216      237      +21     
+ Misses        221      200      -21     
Impacted Files Coverage Δ
src/config.ts 84.07% <100.00%> (+8.84%) ⬆️
src/metadata.ts 36.09% <100.00%> (+3.00%) ⬆️
src/tag.ts 66.66% <0.00%> (+19.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamacku jamacku linked an issue Oct 19, 2022 that may be closed by this pull request
3 tasks
@jamacku jamacku merged commit 3b2603e into redhat-plumbers-in-action:main Oct 19, 2022
@jamacku jamacku deleted the tests branch October 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More tests and increse of test coverage 📈 🧪
1 participant