Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Refactor / Test for Flask 3.0 #506

Closed
sadsfae opened this issue Jun 26, 2024 · 3 comments
Closed

[RFE] Refactor / Test for Flask 3.0 #506

sadsfae opened this issue Jun 26, 2024 · 3 comments

Comments

@sadsfae
Copy link
Member

sadsfae commented Jun 26, 2024

Flask 2.3.x is the latest stable release series for Flask, this RFE would cover any refactoring and testing we'd need to get it integrated into QUADS 2 (we're currently on 2.2.5)

https://flask.palletsprojects.com/en/2.3.x/changes/

Flask 3.0 or greater is now the default python3-flask major version for at least Fedora 40 and onwards, while we're still running Flask 2.2.5. There are breaking changes between 2.2.5 -> 3.0 (introduced in 2.3) and we'll need to refactor and test.

https://flask.palletsprojects.com/en/3.0.x/changes/#version-3-0-3

@sadsfae
Copy link
Member Author

sadsfae commented Aug 29, 2024

@grafuls @kambiz-aghaiepour bumping priority on this, Fedora 40 has already upgraded their system python3-flask package all the way to 3.0.3:

https://fedora.mirrorservice.org/fedora/linux/updates/40/Everything/x86_64/Packages/p/python3-flask-3.0.3-4.fc40.noarch.rpm

This means that Fedora 40 QUADS users will have issues until this is refactored.

@sadsfae sadsfae changed the title [RFE] Refactor / Test for Flask 2.3.x [RFE] Refactor / Test for Flask 2.3 and 3.0 Aug 29, 2024
@sadsfae sadsfae changed the title [RFE] Refactor / Test for Flask 2.3 and 3.0 [RFE] Refactor / Test for Flask 3.0 Aug 29, 2024
@sadsfae
Copy link
Member Author

sadsfae commented Aug 29, 2024

Looks like most of what might break is just what's under the Remove previously deprecated code section here: https://flask.palletsprojects.com/en/3.0.x/changes/#version-2-3-0

From 2.3 -> 3.0 this is what was removed:

pallets/flask#5223

@sadsfae
Copy link
Member Author

sadsfae commented Sep 20, 2024

Closing this as it's completed.

@sadsfae sadsfae closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant