Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add support for installing dependencies in the extest install-vsix command #726

Closed
priyamsahoo opened this issue Apr 4, 2023 · 0 comments · Fixed by #808
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@priyamsahoo
Copy link

Description:

The automatic building of the extension is not proper in certain cases due to vsce linking bugs. To work around this issue, we generate our own .vsix file and run extest install-vsix before running the actual ui tests.

However, our extension has dependencies on other extensions, and there is no option to install dependencies in the extest install-vsix command, although the --install_dependencies arg is present in extest setup-tests. Thus, to overcome this, we need to use an additional command, extest install-from-marketplace, to install the dependencies before running the tests. This creates a long chain of dependencies, resulting in a complicated testing script.

Eg:

"test-ui": "extest get-vscode -c 1.71.0 -s out/test-resources && extest get-chromedriver -s out/test-resources && extest install-vsix -f custom-built.vsix -e out/ext -s out/test-resources && extest install-from-marketplace dependent.extension.1 dependent.extension.2 -e out/ext -s out/test-resources && extest run-tests -s out/test-resources -e out/ext --code_settings test/testFixtures/settings.json out/client/test/ui-test/allTestsSuite.js"

Proposal:

  1. Add --install_dependencies arg to the extest install-vsix command. This will allow for the installation of dependencies without having to run another command for it.
  2. Alternately, add a new arg to the extest setup-tests and extest setup-and-run command that allows for custom scripts to build the extension before installing.
@djelinek djelinek added this to the NEXT milestone May 18, 2023
@djelinek djelinek added the enhancement New feature or request label May 18, 2023
@djelinek djelinek self-assigned this May 30, 2023
@djelinek djelinek changed the title Add support for installing dependencies in the extest install-vsix command [Request] Add support for installing dependencies in the extest install-vsix command May 30, 2023
@djelinek djelinek modified the milestones: NEXT, 5.10.0 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants