-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenDialog doesn't work on mac #40
Comments
The dialog is indeed broken on mac, and I'm not quite able to get it working. Therefore I am putting together a little extension to go along with the tester that would allow opening files/folders using a command. That should circumvent any need for open dialog and should be more stable in the end. It shall be included into the next release. |
Hi, I've come across a similar problem. In my case, the extension I would like to test provides this functionality:
In this case, the dialog is opened by the vscode extension I am testing, so I think it would be amazing if Mac support was eventually added. Is it an issue with the 'node-key-sender' npm module and its compatibility with Mac? |
Very much so. Specifically this issue. I understand the need for dialog handling, but so far I've failed to find a way to get it all working properly without writing it all myself. |
Hi, I'm able to get a workaround for this using robotjs on VSCode 1.40 [OSX 10.14.6]. This work well when i run my tests from Mac terminal, but fails when i run from VSCode terminal.
|
Robotjs definitely is a worthy alternative, but they have issues with newer versions of nodejs. As in I can't currently use robotjs with nodejs newer than version 8. Once they get a fix released, I'd be glad to try it out. |
Fixed as per #56, hopefully :) |
Hi,
Using vscode-extension-tester, I'm trying to do this 'workbench.executeCommand('Workspaces: Add Folder to Workspace...');' which opens a native dialog. I'm using
const dialog = await DialogHandler.getOpenDialog();
dialog.selectPath($WORKSPACE_PATH)
dialog.confirm();
This doesn't work and dialog stays open. Let me if this works in mac or any alternate approaches to open a folder/workspace in vscode. [I just need a way to add an empty folder to the vscode and from there i'm good testing my extension]
The text was updated successfully, but these errors were encountered: