Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Request] Allow to generate extension test coverage using c8 plugin #1160

Closed
djelinek opened this issue Feb 27, 2024 · 4 comments · Fixed by #1234
Closed

[🚀 Request] Allow to generate extension test coverage using c8 plugin #1160

djelinek opened this issue Feb 27, 2024 · 4 comments · Fixed by #1234
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@djelinek
Copy link
Collaborator

Describe the request

generate test coverage reports for extension tested by ExTester

https://www.npmjs.com/package/c8

Usage

e38708b

@djelinek djelinek added enhancement New feature or request new-issue New issue which was not discussed yet labels Feb 27, 2024
@djelinek djelinek added this to the NEXT milestone Feb 27, 2024
@djelinek djelinek removed this from the NEXT milestone Feb 27, 2024
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Mar 20, 2024
@djelinek
Copy link
Collaborator Author

Hi @TamiTakamiya We can continue on this issue with your work on test coverage.

FYI I was looking for reason why the --extensionDevelopmentPath flag was removed from ExTester API. The reason is simple, in past we have decided to chose path where we are executing tests against packed VSIX extension and not the run from source in runtime.

I would like to do not mix these to approaches by adding mentioned flag back at the moment.

But it should be possible to provide new ExTester flag - eg --coverage which will do whole magic in ExTester backend without changes WDYT?

@djelinek djelinek moved this from New to Backlog in ExTester Mar 20, 2024
@djelinek djelinek added this to the BACKLOG milestone Mar 20, 2024
@TamiTakamiya
Copy link
Contributor

@djelinek Thanks for the updates. I started looking at this again with the latest code base.

@TamiTakamiya
Copy link
Contributor

I was thinking of using nyc instead of c8 simply because we have been using nyc in our project. However, I got to know that Microsoft's vscode-test-cli now supports code coverage through c8 and it is supporting the --coverage flag that @djelinek suggested above. I will take a look at their code and consider how ExTester code can be modified to support the flag.

@TamiTakamiya
Copy link
Contributor

Draft PR #1227 was created. I will add some more refinements and send it for review. Thanks.

@djelinek djelinek moved this from Backlog to In Progress in ExTester Apr 29, 2024
@djelinek djelinek modified the milestones: BACKLOG, NEXT Apr 29, 2024
@djelinek djelinek moved this from In Progress to In Review in ExTester Apr 30, 2024
@djelinek djelinek linked a pull request Apr 30, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in ExTester Apr 30, 2024
@djelinek djelinek modified the milestones: NEXT, 8.2.0 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants