Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecation warning about backend.auth.keys #31

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

04kash
Copy link

@04kash 04kash commented Jun 28, 2024

Description of the change

Fixed default configuration to remove deprecation warning about backend.auth.keys by replacing it with https://github.com/backstage/backstage/blob/master/beps/0007-auth-external-services/README.md#the-legacy-access-type

Existing or Associated Issue(s)

Fixes: https://issues.redhat.com/browse/RHIDP-2716

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@coreydaley
Copy link
Member

I think that you also need to run the pre-commit hook to regenerate the schema and update the README

Signed-off-by: Kashish Mittal <[email protected]>
@rm3l
Copy link
Member

rm3l commented Jul 1, 2024

@openshift-cherrypick-robot

@rm3l: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to this:

/cc @rm3l
/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested a review from rm3l July 1, 2024 08:35
@04kash 04kash changed the title [WIP] Removed deprecation warning about backend.auth.keys Removed deprecation warning about backend.auth.keys Jul 2, 2024
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not passing because the latest tag for quay.io/janus-idp/backstage-showcase is outdated, and the changes here won't work on RHDH 1.1

Logs
/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1481
          throw new Error(
                ^

Error: Failed to instantiate service 'core.tokenManager' for 'search' because the factory function threw an error, Error: Failed to instantiate service 'core.tokenManager' because createRootContext threw an error, Error: You must configure at least one key in backend.auth.keys for production.
    at /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1481:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async BackendInitializer.getInitDeps_fn (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1644:20)
    at async /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1779:32
    at async processNode (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1302:22)
    at async Promise.all (index 0)
    at async processMoreNodes (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1297:7)
    at async _DependencyGraph.parallelTopologicalTraversal (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1308:5)
    at async /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1777:9
    at async Promise.all (index 4)
    at async BackendInitializer.doStart_fn (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1757:3)
    at async BackendInitializer.start (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1611:5)
    at async BackstageBackend.start (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1881:5)

Node.js v18.18.2

I think quay.io/janus-idp/backstage-showcase:latest should be updated to the latest stable version of the Showcase app.
See https://redhat-internal.slack.com/archives/C04CUSD4JSG/p1720191475569659

/hold

@coreydaley
Copy link
Member

@rm3l So do we need to change the image here to point to next instead?

@rm3l
Copy link
Member

rm3l commented Jul 12, 2024

@rm3l So do we need to change the image here to point to next instead?

We discussed in https://redhat-internal.slack.com/archives/C04CUSD4JSG/p1720191475569659 (https://issues.redhat.com/browse/RHIDP-3157) that it would probably make more sense to use the downstream RHDH image here. next tag may be unstable to be used in the Helm/Operator PR tests.
@04kash Could you please update the image in values.yaml to use quay.io/rhdh/rhdh-hub-rhel9:latest instead of the outdated quay.io/janus-idp/backstage-showcase:latest ? The test should pass with the RHDH image..
I'm making similar change in the operator repo.

@coreydaley
Copy link
Member

/hold cancel

@coreydaley
Copy link
Member

/lgtm

@coreydaley
Copy link
Member

/approve

@coreydaley
Copy link
Member

@04kash Are you ready for us to merge this?

@04kash
Copy link
Author

04kash commented Jul 12, 2024

@04kash Are you ready for us to merge this?

Yes

@coreydaley coreydaley merged commit 975b738 into redhat-developer:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants