Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuteJavaCodeLensCollector has a private unused method #684

Closed
jeffmaury opened this issue Jul 28, 2022 · 3 comments
Closed

QuteJavaCodeLensCollector has a private unused method #684

jeffmaury opened this issue Jul 28, 2022 · 3 comments
Assignees
Labels
debt good first issue Good for newcomers
Milestone

Comments

@jeffmaury
Copy link
Member

private static List<DataModelParameter> createParameter(FieldDeclaration node) {

@rgrunber rgrunber added good first issue Good for newcomers debt labels Aug 3, 2022
@rgrunber
Copy link
Member

rgrunber commented Aug 3, 2022

This method doesn't appear to have ever done anything. It was removed in bb2d2c9#diff-1d7cfc4737077af167c0f687b94de383a2135b3987cc923f0da2ce9ff67019a6L90 . @angelozerr , is there something we're missing here ?

@angelozerr
Copy link
Contributor

@rgrunber this method alread exists

private static List<DataModelParameter> createParameter(FieldDeclaration node) {
and we should remove it.

@datho7561
Copy link
Contributor

Fixed in #769

@datho7561 datho7561 assigned angelozerr and unassigned datho7561 Feb 6, 2023
@datho7561 datho7561 added this to the 0.14.0 milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

4 participants