Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method/function completions don't (consistently?) use an insert handler with parens for args #610

Open
SCWells72 opened this issue Nov 22, 2024 · 1 comment

Comments

@SCWells72
Copy link

First off, great work on this! It's going to significantly improve the lives of my own plugin's users who pair it with the free Community Edition IDEs by providing quite reasonable JS/TS/CSS support.

One thing I've noticed when playing with it is that when code completions are offered for methods and functions, it doesn't seem to use ParenthesesInsertHandler#NO_PARAMETERS/WITH_PARAMETERS, so the user has to add the parentheses manually. It's not a huge thing, but it's definitely a solid quality-of-life feature that makes overall typing of code so much more seamless.

I've also noticed that the signature information displayed as the completion lookup element tail text doesn't consistently show the signature. It seems to be missing at first and then fills in as I cursor up and down through the offered completions. Perhaps that's related?

Anyway, let me know if I can offer any other useful information, and thanks again for the wonderful work!

@angelozerr
Copy link
Contributor

First off, great work on this!

Thanks!

Don't hesitate to write a review at https://plugins.jetbrains.com/plugin/23257-lsp4ij/reviews to help us to promote LSP4IJ.

It's going to significantly improve the lives of my own plugin's users who pair it with the free Community Edition IDEs by providing quite reasonable JS/TS/CSS support.

One thing I've noticed when playing with it is that when code completions are offered for methods and functions, it doesn't seem to use ParenthesesInsertHandler#NO_PARAMETERS/WITH_PARAMETERS, so the user has to add the parentheses manually. It's not a huge thing, but it's definitely a solid quality-of-life feature that makes overall typing of code so much more seamless.

This feature should be managed with the language server (by using LSP snippet). Perhaps it is a configuration of the typescript language server https://github.com/typescript-language-server/typescript-language-server/blob/master/docs/configuration.md that you can configure with the LSP console https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserDefinedLanguageServer.md#configuration-tab.

I've also noticed that the signature information displayed as the completion lookup element tail text doesn't consistently show the signature. It seems to be missing at first and then fills in as I cursor up and down through the offered completions. Perhaps that's related?

Same thing, those signature are managed with the language server, perhaps you can configure it?

Anyway, let me know if I can offer any other useful information, and thanks again for the wonderful work!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants