Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including the LSP4IJ versioning information in the initialize request #603

Open
rcjsuen opened this issue Nov 19, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rcjsuen
Copy link

rcjsuen commented Nov 19, 2024

{
  "clientInfo": {
    "name": "IntelliJ",
    "version": "GoLand (build GO-241.18034.61)"
  }
}
  1. The initialize request has clientInfo but it only tells me what kind of JetBrains IDE is being used. Including the version of the LSP4IJ library in the clientInfo would be useful.
  2. It seems strange that the name is IntelliJ and the version is GoLand when IntelliJ is the Java IDE so I'm not sure why clientInfo.name is IntelliJ instead of GoLand. 🤔
@angelozerr
Copy link
Contributor

{
  "clientInfo": {
    "name": "IntelliJ",
    "version": "GoLand (build GO-241.18034.61)"
  }
}
  1. The initialize request has clientInfo but it only tells me what kind of JetBrains IDE is being used. Including the version of the LSP4IJ library in the clientInfo would be useful.
  2. It seems strange that the name is IntelliJ and the version is GoLand when IntelliJ is the Java IDE so I'm not sure why clientInfo.name is IntelliJ instead of GoLand. 🤔

It is because it is hard coded :) https://github.com/redhat-developer/lsp4ij/blob/main/src%2Fmain%2Fjava%2Fcom%2Fredhat%2Fdevtools%2Flsp4ij%2Finternal%2FIntelliJPlatformUtils.java#L22

Any contribution are welcome!

@angelozerr angelozerr added enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants