-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diagnostic tag for unnecessary refreshed very frequently. #488
Comments
@angelozerr is it the same as #485 ? |
The fix of #485 was to highlight semantic tokens for the whole file by implementing For diagnostics, we extends an ExternalAnnotator which should be used according to the documentation to implement a validator without Psi. It could be interesting to try to implement HighlightVisitor like we did for semantic tokens and see if it fixes the issue, but according to the doc HighlightVisitor is usedto manage highlighting and not validation,but we could try it. @CppCXY if you have time, you could try it. |
An another idea is to implement only Annotator to create only annotation for the editing PsiElement range. This idea could improve the UI since we will create only annotations for the range of the PsiElement instead of re-creating all annotations for the whole file. |
So I think the reason might be that the rendering is too fast here. |
Thanks @CppCXY for your feedback! |
@CppCXY I have tested byinstalling your IJ plugin and I have no flicker. Could you please share files / project that youare testing please. |
which plugin, your install? |
I tested it on my home computer, and there was no flickering at all. I'll try with a large file. |
Maybe the CPU at home is better, so it's difficult to reproduce this issue now. |
You mean that you cannot reproduce with your computer at home? |
yes, I think this issue doesn't need to be resolved. |
OK but I think it could be interesting to try with annotator to see if it will improve performance. |
see:
The text was updated successfully, but these errors were encountered: