Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List properties are incorrectly recognized/validated #1248

Open
fbricon opened this issue Oct 31, 2023 · 4 comments
Open

List properties are incorrectly recognized/validated #1248

fbricon opened this issue Oct 31, 2023 · 4 comments
Assignees
Labels
bug Something isn't working validation

Comments

@fbricon
Copy link
Contributor

fbricon commented Oct 31, 2023

In application properties,

quarkus.native.resources.includes=names

is shown with an "unknown property" warning, but it's perfectly valid, as per https://quarkus.io/guides/writing-native-applications-tips#including-resources

We expect an indexed property instead:
Screenshot 2023-10-31 at 13 16 17

Screenshot 2023-10-31 at 13 05 46
@fbricon fbricon added bug Something isn't working validation labels Oct 31, 2023
@fbricon
Copy link
Contributor Author

fbricon commented Oct 31, 2023

@angelozerr
Copy link
Contributor

also see https://quarkus.io/guides/config-reference#indexed-properties

Thanks for the info.

We need to improve that. I wonder if completion should return too only quarkus.native.resources.excludes (without [*])?

@fbricon
Copy link
Contributor Author

fbricon commented Nov 7, 2023

Without [*] please

@angelozerr
Copy link
Contributor

Without [*] please

Ok we can do that, but we should do that only for properties which ends with [*]. This behaviour should be done on MicroProfile Language Server (LSP4MP)

@fbricon fbricon added this to the 1.30.0 milestone Nov 7, 2023
@angelozerr angelozerr modified the milestones: 1.30.0, 1.31.0 Nov 23, 2023
@fbricon fbricon modified the milestones: 1.31.0, 1.31.1 Jan 8, 2024
@fbricon fbricon removed this from the 1.31.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
Development

No branches or pull requests

2 participants