Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat http statuses >=400 as connection errors rather than auth errors #1265

Open
jrichter1 opened this issue Feb 13, 2018 · 1 comment
Open

Treat http statuses >=400 as connection errors rather than auth errors #1265

jrichter1 opened this issue Feb 13, 2018 · 1 comment
Labels
kind/question priority/major

Comments

@jrichter1
Copy link
Collaborator

jrichter1 commented Feb 13, 2018 •
edited
Loading

Trying to log in started failing with the 'invalid account information' message, yet it was caused by the server returning 500 (internal server error).
Would it make more sense to treat such responses as connection errors and leave the authentication error handling solely for 401 responses?

@dgolovin WDYT?
@dgolovin
Copy link
Contributor

The reason is my changes in request service, the fix is here #1264, but some test issues still have to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgolovin @jrichter1