Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug when 2+ Podpreset are trying to apply presets, only the last one will be applied #1

Open
mahmoudcb opened this issue Jun 9, 2020 · 5 comments · May be fixed by #29
Open

A bug when 2+ Podpreset are trying to apply presets, only the last one will be applied #1

mahmoudcb opened this issue Jun 9, 2020 · 5 comments · May be fixed by #29

Comments

@mahmoudcb
Copy link

I have 2 PodPresets that should be applied to the Pod. Here are the logs

{"level":"info","ts":1591409049.4927325,"logger":"podpreset_webhook_handler","msg":"PodPreset matches pod labels","PodPreset":"chartboost-config-repo","Pod":""}
{"level":"info","ts":1591409049.4928012,"logger":"podpreset_webhook_handler","msg":"PodPreset matches pod labels","PodPreset":"datadog-agent-host","Pod":""}
{"level":"info","ts":1591409049.4928439,"logger":"podpreset_webhook_handler","msg":"applied podpresets","Names":"datadog-agent-host,datadog-agent-host","Pod Name":"test-deployment-7f7f79757f-"}

It's clear from the logs that it is somehow trying to apply datadog-agent-host 2 times.

I'm suspecting mutatePodsFn and filterPodPresets functions aren't returning the correct lists.
@danopia
Copy link

danopia commented Oct 22, 2020 •
edited
Loading

Hmm, this looks like a duplicate of #2 which was supposedly addressed by #3. Do you still see the issue?

@riccardo-salamanna
Copy link

Hi - i am using the latest tag on an EKS cluster but it seems that the labels matching is being completely ingnored, any pod is matching the last podpreset. I also see that the changes in the PR you mention #3 doesn't seem to be present in master... thanks for your support

@tjabodog
Copy link

@danopia The #3 patch did fix this issue. However this fix have then been lost/reverted in one of the later commits.

@danopia
Copy link

danopia commented Nov 10, 2021

Yes, I agree, the fix I referenced was reverted by this huge PR: #11

I've never actually used this project so I'll be unsubscribing from this thread. Apologies

@konman1989
Copy link

konman1989 commented Apr 26, 2022 •
edited
Loading

@sabre1041 @mathianasj any plans to fix this?

dpoetzsch pushed a commit to mondata-dev/podpreset-webhook that referenced this issue Sep 23, 2022
reapplying the patch from redhat-cop#3 to fix redhat-cop#1
ded60a8
@dpoetzsch dpoetzsch linked a pull request Sep 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix https://github.com/redhat-cop/podpreset-webhook/issues/1 mondata-dev/podpreset-webhook
5 participants
@danopia @tjabodog @mahmoudcb @konman1989 @riccardo-salamanna