Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using ISTIO_QUIT_API=http://127.0.0.1:15020 #9

Open
haf-afa opened this issue Oct 21, 2019 · 2 comments
Open

Default to using ISTIO_QUIT_API=http://127.0.0.1:15020 #9

haf-afa opened this issue Oct 21, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@haf-afa
Copy link

haf-afa commented Oct 21, 2019

Since I put scuttle in front of my program it would make sense that it does its job assuming an up-to-date version of istio.

@haf-afa haf-afa changed the title Default to using ENVOY_ADMIN_API=http://127.0.0.1:15020 Default to using ISTIO_QUIT_API=http://127.0.0.1:15020 Oct 21, 2019
@linjmeyer linjmeyer added good first issue Good for newcomers enhancement New feature or request labels Dec 2, 2019
@linjmeyer
Copy link

I have no issues with this being the default, but a new env variable should be added to enable/disable Scuttle with the default to false. This is necessary so that non-kubernetes environments can have Scuttle in the docker image without breaking. For example, using docker run should still work with scuttle on a developers local machine.

Feel free to do a PR, otherwise I can pick it up next week. Thanks for the suggestion!

@ptzianos
Copy link

What if we use a variable like ISTIO_VERSION to show scuttle what it has to deal with? Then we could set automatically sensible defaults like in the case of ISTIO_QUIT_API and ENVOY_ADMIN_API (#12). It's also easy to spot if it is not configured properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants