Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix Tolerations setting for NooBaa in standalone mode #1759

Open
maratsal opened this issue Jul 29, 2022 · 0 comments
Open

Bug: Fix Tolerations setting for NooBaa in standalone mode #1759

maratsal opened this issue Jul 29, 2022 · 0 comments

Comments

@maratsal
Copy link

Currently if you deploy NooBaa in standalone mode with ODF it is not possible to set tolerations by method described on this page - https://access.redhat.com/articles/6408481

The issue because of this commit - 78d3d57 - which wanted to disable Affinity for standalone setup, but also removes tolerations. Please see this piece of code -

if !r.IsNoobaaStandalone {
placement := getPlacement(sc, "noobaa-core")
nb.Spec.Tolerations = placement.Tolerations
nb.Spec.Affinity = &corev1.Affinity{NodeAffinity: placement.NodeAffinity}
}

Possible solution would be to have it like this:

+	placement := getPlacement(sc, "noobaa-core")
+	nb.Spec.Tolerations = placement.Tolerations
	if !r.IsNoobaaStandalone {
-		placement := getPlacement(sc, "noobaa-core")
-		nb.Spec.Tolerations = placement.Tolerations
		nb.Spec.Affinity = &corev1.Affinity{NodeAffinity: placement.NodeAffinity}
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant