Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor suggested improvements for users' convenience #20

Open
qleclerc opened this issue Jun 2, 2020 · 0 comments
Open

Minor suggested improvements for users' convenience #20

qleclerc opened this issue Jun 2, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@qleclerc
Copy link

qleclerc commented Jun 2, 2020

Everything works great, just 2 minor suggested improvements to make users' lives easier:

  • You have custom error catching if max_k is too large in asmodee() , would be nice to also have custom error catching for fixed_k and alpha

  • The data you pass to asmodee() actually needs to follow a specific formatting, but that's not specified anywhere, again would be nice to write that somewhere (not sure where though)

@dirkschumacher dirkschumacher added good first issue Good for newcomers documentation Improvements or additions to documentation and removed good first issue Good for newcomers labels Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants