Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R 4.0.0 breaks current tests #24

Open
TimTaylor opened this issue May 4, 2020 · 3 comments
Open

R 4.0.0 breaks current tests #24

TimTaylor opened this issue May 4, 2020 · 3 comments

Comments

@TimTaylor
Copy link
Member

For info - a few of the tests now error due to the the matrix class now inheriting from array in R 4.0.0. This mainly affects the tests that compare to the rds files generated under an old version of R but also one of the tests in test_cumulate.

@thibautjombart
Copy link
Contributor

Thanks for flagging this. I will get to it as soon as I get a chance.

@TimTaylor
Copy link
Member Author

If you want to keep the tests for older versions of R then a quick hacky fix is to add something like

attributes(pred_1)$class <- attributes(pred_1)$class[(1:2)]

in the tests where the projections utilise rds files.

However given that this is just for tests and won't break any code, it may be better to just update the reference cases and only focus on R 4.0 for testing.

@TimTaylor
Copy link
Member Author

TimTaylor commented May 6, 2020

Most of these should now have intermediate fixes in #25. I've not been able to get vdiffr working on my local machine so have not checked if image tests are affected by R 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants