-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
score
vs match
#58
Comments
This issue has a large overlap with #51.
"Confidence" here just means "when the service says |
|
@VladimirAlexiev
Let's describe further what you mean by "set" and the handling that surrounds that on the client side... Irregardless if the Recon service has scored 1 candidate very high, and selected it as a @wetneb Line 454 in fc4c152
But in general, I think we want section 4. Reconciliation Queries to make it a bit more clear on how clients might use |
The client might... and the server could... It's fine to keep it open, but at the same time we should describe what the canonical client (OR) does, and what a reasonable server should do. BTW, what does OR do if there are several candidates with match=true and "auto-match" is selected? |
I think we want to avoid adding to the official spec what any 1 particular client does, like OR. That's why I suggest a completely different document for describing OR or other example client handling and maybe just link out to it throughout the spec.
Not sure, dive into the code? I'm also not sure how that might impact the Pool of ReconCandidates https://github.com/OpenRefine/OpenRefine/blob/5639f1b2f17303b03026629d763dcb6fef98550b/main/src/com/google/refine/util/Pool.java#L73 |
I am probably quite biased here but I'd prefer to avoid referring to OR too much. The more we can abstract ourselves away from it, the more likely we are to come up with improvements that make sense for other clients too.
I don't know either, I would guess that it takes the first (highest-ranking) candidate with match=true, but I haven't checked. |
Recon spec
https://reconciliation-api.github.io/specs/latest/#reconciliation-query-responses includes two characteristics that determine the "quality" of a candidate:
score
(numeric) andmatch
(boolean)I think these rules would make sense:
match
should be set for only 0 or 1 candidatesmatch
should be set for the candidate with highestscore
, if its score is sufficiently high, and sufficiently higher than all other candidate scoresDo you agree? I can add them to the spec.
WD recon
match
@vasoto observed inconsistencies in these characteristics as returned by Wikidata recon. Can you confirm these observations, because looking at the code it seems this can't happen:
match: true
match: true
OpenRefine
(Answered) OR has two functions to act upon these characteristics:
I couldn't find any documentation defining "confidence" through the two characteristics.
@thadguidry and @wetneb, can you comment?
The text was updated successfully, but these errors were encountered: