Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android issue: Annotation pop up not showing up #335

Open
jsmueller7 opened this issue Dec 9, 2024 · 5 comments
Open

Android issue: Annotation pop up not showing up #335

jsmueller7 opened this issue Dec 9, 2024 · 5 comments

Comments

@jsmueller7
Copy link

jsmueller7 commented Dec 9, 2024

While trying to debug issue #334 I also tested on the staging server (netlify.app). Based upon that I'd expect that #334 persists. Additionaly the annotation pop up didn't appear any more after I had selected text. The pop up did appear though, when I selected text through a PC and an inspect tab on my android device.

The header bar #281 issue fix lead to an unability to open the side bar. I have been testing with a very small screen though.

@rsimon
Copy link
Member

rsimon commented Dec 9, 2024

When collapsed, the header bar should display a '...' icon which folds out an additional panel, which holds the collapsed tools. I should add, though, that we only support tablets at the moment. Phones will, in general, have too limited screen space for much of the interface to work.

I can't reproduce the popup issue, though. I tried (with an Android phone), and that seemed to work just fine. I note, however, that our staging system is:
https://recogito-staging.covecollective.org/

I don't think the one we used initially, (vico-design.netlify.app) is actually being updated. I'll double check. (Because this is running through my personal Netlify account.) But I think we should take down this instance, in favour of the official covecollective staging instance.

@rsimon
Copy link
Member

rsimon commented Dec 9, 2024

Sorry - I'm correcting myself. The vico-design version is on the Performant Netlify and it looks like it is being updated from the main branch.

Also: I think I can reproduce the missing popup now. This seems to be specific to PDF? (I tried with TEI initially, and that works.)

@jsmueller7
Copy link
Author

It could be. I've only tested with PDF.

@jsmueller7
Copy link
Author

I've just done some more testing. With plain text this also happens, TEI seems not to be affected.
Weird: Also #334 isn't occuring with TEI, so there might be a connection.

@jsmueller7
Copy link
Author

OK, that was too hasty. The pop-up that is not displayed relates to PDF and TXT, not TEI. But #334 only applies to PDF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants