Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RKOTLIN-1137] Fix incorrect currentTime() for Android devices on API 25 and blow #1850

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stavfx
Copy link

@stavfx stavfx commented Oct 30, 2024

Also add millisecond precision.

This fixes #1849

Copy link

cla-bot bot commented Oct 30, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @stavfx. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@stavfx
Copy link
Author

stavfx commented Oct 30, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 30, 2024
Copy link

cla-bot bot commented Oct 30, 2024

The cla-bot has been summoned, and re-checked this pull request!

@stavfx stavfx changed the title Fix incorrect currentTime() for Android devices on API 25 and blow [RKOTLIN-1137] Fix incorrect currentTime() for Android devices on API 25 and blow Nov 1, 2024
@stavfx
Copy link
Author

stavfx commented Nov 1, 2024

Should I aim this PR at the 'main' branch, or 'community'?
And did I update the changelog in the correct spot?
I'm not sure what the process is now after the deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmInstant.now() returns wrong value on API 25 and below
1 participant