RNET-1168: Make mongodb connection string used for tests configurable #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmorkos
force-pushed
the
km/configurable_connstr
branch
from
13aef63
to
f45831a
Compare
kmorkos
force-pushed
the
km/configurable_connstr
branch
from
f45831a
to
d8bb4b5
Compare
Pull Request Test Coverage Report for Build 10098296353Details
💛 - Coveralls |
kmorkos
commented
Jul 25, 2024
Comment on lines
-197
to
-200
| else | ||
| { | ||
| _baasClient = await BaasClient.Docker(BaasUri!, "local", TestHelpers.Output); | ||
| } |
There was a problem hiding this comment.
From what I can tell, this client would always match the one initialized by ExtractBaasSettingsAsync so avoiding threading the connection string here, but lmk if there's some other workflow that relies on this
There was a problem hiding this comment.
This is invoked when testing against a local baas docker image, so we should probably bring it back, even if most of the time people test against baasaas.
|
@nirinchev bumping this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3653
Confirmed that this works in the baas CI and all tests pass as expected.
TODO