Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some resharper warnings #3406

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Fix some resharper warnings #3406

merged 5 commits into from
Aug 3, 2023

Conversation

nirinchev
Copy link
Member

Description

This fixes a wide range of warnings/suggestions by ReSharper, primarily in the Realm project. Don't plan to go through the tests at this point, but figured I'd spend 20-30 minutes on the main assemblies. For the most part, those are purely cosmetic and functionally equivalent (e.g. removing usings, marking members private). There are a few categories of warnings that may yield a minor positive impact on users:

  • Removed dead code
  • Marked struct methods as readonly to avoid copying the struct prior to execution (this would have biggest impact on RealmValue and PrimitiveValue).
  • Some ambiguous docs references.

TODO

  • Changelog entry
  • Tests (if applicable)

@coveralls
Copy link

coveralls commented Aug 2, 2023

Pull Request Test Coverage Report for Build 5750151873

  • 50 of 58 (86.21%) changed or added relevant lines in 21 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 82.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Helpers/SerializationHelper.cs 0 1 0.0%
Realm/Realm/Schema/ObjectSchema.cs 0 1 0.0%
Realm/Realm/Linq/RealmResultsVisitor.cs 8 10 80.0%
Realm/Realm/DatabaseTypes/RealmCollectionBase.cs 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Exceptions/RealmException.cs 2 78.95%
Realm/Realm/Handles/SessionHandle.cs 2 84.65%
Totals Coverage Status
Change from base Build 5743612663: 0.1%
Covered Lines: 6296
Relevant Lines: 7462

💛 - Coveralls

@nirinchev nirinchev added the no-changelog Used to skip the changelog check label Aug 2, 2023
@nirinchev nirinchev requested a review from papafe August 2, 2023 07:57
@nirinchev nirinchev merged commit daaccf2 into main Aug 3, 2023
@nirinchev nirinchev deleted the ni/resharper branch August 3, 2023 12:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants