Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to open a synced realm without sync configuration. #234

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

leemaguire
Copy link
Contributor

@leemaguire leemaguire commented Jul 23, 2024

Add ability to open a synced realm without a flexible sync configuration.

auto local_config = realm::db_config();
local_config.set_path(path);
local_config.enable_forced_sync_history(); // allows a synced realm to be used with a local config.

@leemaguire leemaguire added the no-jira-ticket Skip checking the PR title for Jira reference label Jul 23, 2024
@leemaguire leemaguire self-assigned this Jul 23, 2024
@leemaguire leemaguire marked this pull request as ready for review July 23, 2024 14:51
tests/sync/flexible_sync_tests.cpp Show resolved Hide resolved
tests/sync/flexible_sync_tests.cpp Show resolved Hide resolved
tests/sync/flexible_sync_tests.cpp Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@dianaafanador3 dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments and some minor questions

@leemaguire leemaguire merged commit 98135ff into main Jul 25, 2024
47 of 50 checks passed
@leemaguire leemaguire deleted the lm/local-sync-realm branch July 25, 2024 12:08
@adamski
Copy link

adamski commented Aug 2, 2024

@leemaguire I assume in order to move the local realm to be synced, one would need to explicitly set the path to be the same in both cases, rather than use the default path given when setting it up via an app and user?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants