Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated bindgen spec and helpers #7995

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Updated bindgen spec and helpers #7995

merged 1 commit into from
Aug 26, 2024

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Aug 23, 2024 •
edited
Loading

What, How & Why?

Related to #7991 (comment)

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kraenhansen kraenhansen self-assigned this Aug 23, 2024
@kraenhansen kraenhansen requested a review from jedelbo August 23, 2024 10:17
@cla-bot cla-bot bot added the cla: yes label Aug 23, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build kraen.hansen_75

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.772%
Files with Coverage Reduction New Missed Lines %
src/realm/parser/driver.cpp 1 87.57%
src/realm/util/serializer.cpp 1 90.43%
test/test_index_string.cpp 1 93.48%
src/realm/mixed.cpp 3 86.75%
src/realm/query_expression.hpp 3 93.65%
src/realm/unicode.cpp 3 83.83%
test/fuzz_group.cpp 3 48.17%
src/realm/util/assert.hpp 4 87.1%
Totals Coverage Status
Change from base Build jorgen.edelbo_401: 0.01%
Covered Lines: 139610
Relevant Lines: 152127
💛 - Coveralls

jedelbo
jedelbo approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks very nice. If you have verified that it will not cause any trouble downstream, then I am fine.

@kraenhansen kraenhansen merged commit 14ea531 into je/local-only Aug 26, 2024
40 of 48 checks passed
@kraenhansen kraenhansen deleted the kh/local-only-bindgen-spec branch August 26, 2024 09:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @jedelbo