Remove ability to synchronize #7991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
reviewed
Aug 21, 2024
src/realm.h
Outdated
| @@ -854,21 +854,6 @@ RLM_API void realm_config_set_scheduler(realm_config_t*, const realm_scheduler_t | |||
| */ | |||
| RLM_API void realm_config_set_sync_config(realm_config_t*, realm_sync_config_t*); | |||
There was a problem hiding this comment.
Should this (and a bunch of other methods in the C API) also be removed?
kraenhansen
reviewed
Aug 23, 2024
Package.swift
Outdated
| @@ -15,7 +15,6 @@ var cxxSettings: [CXXSetting] = [ | |||
| .define("REALM_INSTALL_LIBEXECDIR", to: ""), | |||
| .define("REALM_ENABLE_ASSERTIONS", to: "1"), | |||
| .define("REALM_ENABLE_ENCRYPTION", to: "1"), | |||
| .define("REALM_ENABLE_SYNC", to: "1"), | |||
| .define("REALM_ENABLE_GEOSPATIAL", to: "1"), | |||
| .define("REALM_APP_SERVICES", to: "1"), | |||
There was a problem hiding this comment.
Should this be removed as well?
|
Could this update the |
4 tasks
kraenhansen
added
the
no-jira-ticket
ironage
reviewed
Aug 26, 2024
| @@ -93,9 +93,6 @@ typedef struct realm_results realm_results_t; | |||
|
|
|||
| /* Config types */ | |||
| typedef struct realm_config realm_config_t; | |||
| typedef struct realm_app_config realm_app_config_t; | |||
There was a problem hiding this comment.
there is a reference to "audit" in this file that should be removed
CMakeLists.txt
Outdated
| @@ -268,7 +267,6 @@ if(NOT EMSCRIPTEN) | |||
| endif() | |||
| option(REALM_ENABLE_MEMDEBUG "Add additional memory checks" OFF) | |||
| option(REALM_VALGRIND "Tell the test suite we are running with valgrind" OFF) | |||
| option(REALM_SYNC_MULTIPLEXING "Enables/disables sync session multiplexing by default" ON) | |||
| set(REALM_MAX_BPNODE_SIZE "1000" CACHE STRING "Max B+ tree node size.") | |||
| option(REALM_ENABLE_GEOSPATIAL "Enable geospatial types and queries." ON) | |||
| option(REALM_APP_SERVICES "Enable the default app services implementation." ON) | |||
Comment on lines
156
to
157
| // A factory function which produces an audit implementation. | ||
| std::shared_ptr<AuditConfig> audit_config; |
There was a problem hiding this comment.
We can remove the audit stuff in a subsequent round
test/object-store/CMakeLists.txt
Outdated
| @@ -43,51 +43,6 @@ endif() | |||
|
|
|||
| file(GLOB RESOURCES "*.realm" "../*.pem") | |||
There was a problem hiding this comment.
all the test/*.pem files can be removed
test/object-store/CMakeLists.txt
Outdated
| @@ -116,63 +71,6 @@ create_coverage_target(generate-coverage ObjectStoreTests) | |||
| # add_bundled_test(ObjectStoreTests) | |||
| add_labeled_test(ObjectStoreTests-local objstore-local ObjectStoreTests "~[baas]") | |||
There was a problem hiding this comment.
I think this is redundant now.
| } | ||
| } | ||
|
|
||
| TEST_CASE("KeyPath generation - star notation") { |
There was a problem hiding this comment.
I think this test is still valid, it looks like it was accidentally included in the sync section.
|
|
||
| # Run the setup_baas_host_local.sh script to configure and run baas on the remote host | ||
| # Add -v to this command for verbose script logging | ||
| ./evergreen/setup_baas_host_local.sh -w ./baas-work-dir -u $BAAS_USER $OPT_BAAS_BRANCH $OPT_BAAS_PROXY \ |
There was a problem hiding this comment.
please remove the various baas helper scripts from this evergreen directory
ironage
approved these changes
Aug 27, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed