Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-2178: Fix Realm2JSON help #7984

Merged
merged 1 commit into from
Aug 15, 2024
Merged

RCORE-2178: Fix Realm2JSON help #7984

merged 1 commit into from
Aug 15, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Aug 14, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Aug 14, 2024
@jedelbo jedelbo requested a review from ironage August 14, 2024 13:56
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_394

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 87 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.106%
Files with Coverage Reduction New Missed Lines %
src/realm/array_mixed.cpp 1 94.02%
src/realm/mixed.cpp 1 86.46%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/network/websocket.cpp 1 72.2%
test/fuzz_tester.hpp 1 57.73%
src/realm/cluster.cpp 2 75.85%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/sync/noinst/client_impl_base.cpp 2 82.98%
src/realm/util/future.hpp 3 95.94%
src/realm/table.cpp 4 90.42%
Totals Coverage Status
Change from base Build 2564: -0.02%
Covered Lines: 217374
Relevant Lines: 238595
💛 - Coveralls

ironage
ironage approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@jedelbo jedelbo merged commit c4b5cae into master Aug 15, 2024
45 of 49 checks passed
@jedelbo jedelbo deleted the je/realm2json branch August 15, 2024 07:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

Assignees

@jedelbo jedelbo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedelbo @ironage