Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test file in file-format 24 #7979

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Create test file in file-format 24 #7979

merged 1 commit into from
Aug 13, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Aug 12, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link
Member

@nicola-cab nicola-cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Nice idea to test links and dates also… right now they are not compressed, but we should test that if they get compressed, we don't break them either…

options.logger = test_context.logger;
auto sg = DB::create(*hist, temp_copy, options);
auto wt = sg->start_write();
// rt->to_json(std::cout);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove if not needed.

Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_390

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1020 unchanged lines in 55 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.108%

Files with Coverage Reduction New Missed Lines %
src/realm/array_integer_tpl.hpp 1 76.32%
src/realm/array_string.cpp 1 88.03%
src/realm/array_with_find.hpp 1 98.82%
src/realm/query_state.hpp 1 86.36%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/util/compression.cpp 1 89.62%
test/test_util_network_ssl.cpp 1 89.59%
src/realm/array_blobs_small.hpp 2 80.0%
src/realm/impl/output_stream.cpp 2 82.35%
src/realm/sync/noinst/client_impl_base.cpp 2 82.83%
Totals Coverage Status
Change from base Build jorgen.edelbo_389: 0.02%
Covered Lines: 217365
Relevant Lines: 238579

💛 - Coveralls

@jedelbo jedelbo merged commit ad97af4 into next-major Aug 13, 2024
45 of 49 checks passed
@jedelbo jedelbo deleted the test-upgrade-files branch August 13, 2024 07:57
@jedelbo jedelbo restored the test-upgrade-files branch August 13, 2024 08:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants